[jdk11u-dev] RFR: 8248238: Implementation: JEP 388: Windows AArch64 Support [v3]

[Reka Kovacs]

On Wed, 6 Oct 2021 08:27:55 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> @theRealAph you're right about `push_call_clobbered_registers()`, but I think `call_clobbered_registers()` is actually fine the way it is. The register named `r18_tls` on tip has been renamed to `r18_reserved` in this backport.
>
> Looks to me like the only real issue here is `warn()`. `stop()` doesn't restore the registers, so that's fine. We do want to see all the registers in a register dump. It would be better if `pusha()` were left as it is, but `popa()` did not clobber r18.

I believe this concern is addressed by [openjdk/jdk#5828](https://github.com/openjdk/jdk/pull/5828). Are you okay with leaving this patch as-is and backporting that soon after?

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/301