[jdk11u-dev] RFR: 8248238: Implementation: JEP 388: Windows AArch64 Support [v3]

[Vladimir Kempik]

On Tue, 31 Aug 2021 13:18:50 GMT, Reka Kovacs <github.com+25946952+rnkovacs at openjdk.org> wrote:

>> Main commit of the Windows/AArch64 port.
>> 
>> Also fixes [JDK-8272181](https://bugs.openjdk.java.net/browse/JDK-8272181) by adding [`src/hotspot/os_cpu/windows_aarch64/pauth_windows_aarch64.inline.hpp`](https://github.com/openjdk/jdk11u-dev/pull/301/files#diff-235302dc4618158c4f75771ebbb6f0e4beeee5daf0a537b03ee4253a711268c6), which is needed for a successful Windows-AArch64 build.
>> 
>> Depends on #274 and #299.
>
> Reka Kovacs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   Backport 9604ee82690f89320614b37bfef4178abc869777

> Yes, exartly.
> 
> It could be:
> 
> `push(RegSet::range(r0, r29) R18_RESERVED_ONLY(-r18_tls), sp);`

But it should probably be done here 
https://github.com/openjdk/jdk11u-dev/pull/301/files#diff-0f4150a9c607ccd590bf256daa800c0276144682a92bc6bdced5e8bc1bb81f3aR2548

src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 2557:

> 2555: void MacroAssembler::push_call_clobbered_registers() {
> 2556:   int step = 4 * wordSize;
> 2557:   push(call_clobbered_registers() - RegSet::of(rscratch1, rscratch2), sp);

is it right to substract rscratch1/2 twice, fist in call_clobbered_registers, then here ?

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/301