[jdk11u-dev] RFR: 8248238: Implementation: JEP 388: Windows AArch64 Support [v3]

[Andrew Haley]

On Fri, 3 Sep 2021 09:03:27 GMT, Vladimir Kempik <vkempik at openjdk.org> wrote:

>> Reka Kovacs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:
>> 
>>   Backport 9604ee82690f89320614b37bfef4178abc869777
>
> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 2557:
> 
>> 2555: void MacroAssembler::push_call_clobbered_registers() {
>> 2556:   int step = 4 * wordSize;
>> 2557:   push(call_clobbered_registers() - RegSet::of(rscratch1, rscratch2), sp);
> 
> is it right to substract rscratch1/2 twice, fist in call_clobbered_registers, then here ?

It's not exactly wrong. The readability of the code seems to have suffered in translation.

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/301