[jdk11u-dev] RFR: 8248238: Implementation: JEP 388: Windows AArch64 Support [v3]

[Vladimir Kempik]

On Wed, 8 Sep 2021 08:17:48 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 2557:
>> 
>>> 2555: void MacroAssembler::push_call_clobbered_registers() {
>>> 2556:   int step = 4 * wordSize;
>>> 2557:   push(call_clobbered_registers() - RegSet::of(rscratch1, rscratch2), sp);
>> 
>> is it right to substract rscratch1/2 twice, fist in call_clobbered_registers, then here ?
>
> It's not exactly wrong. The readability of the code seems to have suffered in translation.

please take a look at 

definition:
https://github.com/openjdk/jdk11u-dev/pull/301/files#diff-0f4150a9c607ccd590bf256daa800c0276144682a92bc6bdced5e8bc1bb81f3aR2547

and call site:

https://github.com/openjdk/jdk11u-dev/pull/301/files#diff-9112056f732229b18fec48fb0b20a3fe824de49d0abd41fbdb4202cfe70ad114R1290

call site doesn't expect rscratch2 to be removed from the list

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/301