[jdk17u-dev] RFR: 8267189: Remove duplicated unregistered classes from dynamic archive

[Ioi Lam]

On Thu, 1 Dec 2022 02:55:18 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Hi,
>> 
>> JDK-8275731: CDS archived enums objects are recreated at runtime
>> 
>>  Dependencies:
>> 
>> =>  JDK-8267189: Remove duplicated unregistered classes from dynamic archive
>> * JDK-8268821: Split systemDictionaryShared.cpp
>> * JDK-8269004: Implement ResizableResourceHashtable
>> * JDK-8270061: Change parameter order of ResourceHashtable
>> * JDK-8270803: Reduce CDS API verbosity
>> * JDK-8270489: Support archived heap objects in EpsilonGC
>> 
>> The patch applies clean except manually edit the source file:
>> 
>> * src/hotspot/share/classfile/systemDictionaryShared.hpp
>> Made `static void SystemDictionaryShared::remove_dumptime_info(InstanceKlass*)` public within this context.
>> 
>> Tested jtreg tier1~3, no regression.
>> 
>> Thanks,
>> Leslie Zhai
>
> The description of this PR is not clear. Are you backporting JDK-8267189 because it's required by [JDK-8275731](https://bugs.openjdk.org/browse/JDK-8275731) "CDS archived enums objects are recreated at runtime", which is the ultimate issue that you want to backport?
> 
> Please avoid mentioning JDK-8297543, as it's already closed as a duplicate of JDK-8275731.

> Hi @iklam
> 
> Thanks for your kind response!
> 
> > The description of this PR is not clear.
> 
> I updated the description. Please review it again.
> 
> > Are you backporting JDK-8267189 because it's required by [JDK-8275731](https://bugs.openjdk.org/browse/JDK-8275731) "CDS archived enums objects are recreated at runtime", which is the ultimate issue that you want to backport?
> 
> Yes.
> 
> Thanks, Leslie Zhai

I think the wording of this PR should be changed to something like this:

* Backporting JDK-8267189 as a prerequisite for JDK-8275731 (CDS archived enums objects are recreated at runtime)

You don't need to mention the other issues here. Instead, those issue should be listed in JDK-8275731:

* Add label jdk17u-fix-reques to JDK-8275731
* Add a comment in JDK-8275731, with something like
  * In order to backport this issue to jdk 17u, the following issues must be backported first, in the order of
    1.  JDK-8267189: Remove duplicated unregistered classes from dynamic archive
     2. JDK-XXXXXXX: xxxxxx
     3. JDK-XXXXXXX: xxxxxx
     4. JDK-XXXXXXX: xxxxxx

You should reach an agreement with the jdk17u maintainers first. I would suggest sending mail to the jdk-updates-dev mailing list. See https://mail.openjdk.org/pipermail/jdk-updates-dev/

You listed JDK-8270489 (Support archived heap objects in EpsilonGC) as a prerequisite, but that's a very large change and seems unrelated to the enum problem. More discussion is needed on jdk-updates-dev to decide which set of issues should be backported.

-------------

PR: https://git.openjdk.org/jdk17u-dev/pull/939