[jdk17u-dev] RFR: 8267189: Remove duplicated unregistered classes from dynamic archive

[Leslie Zhai]

On Thu, 1 Dec 2022 20:22:38 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> The description of this PR is not clear. Are you backporting JDK-8267189 because it's required by [JDK-8275731](https://bugs.openjdk.org/browse/JDK-8275731) "CDS archived enums objects are recreated at runtime", which is the ultimate issue that you want to backport?
>> 
>> Please avoid mentioning JDK-8297543, as it's already closed as a duplicate of JDK-8275731.
>
>> Hi @iklam
>> 
>> Thanks for your kind response!
>> 
>> > The description of this PR is not clear.
>> 
>> I updated the description. Please review it again.
>> 
>> > Are you backporting JDK-8267189 because it's required by [JDK-8275731](https://bugs.openjdk.org/browse/JDK-8275731) "CDS archived enums objects are recreated at runtime", which is the ultimate issue that you want to backport?
>> 
>> Yes.
>> 
>> Thanks, Leslie Zhai
> 
> I think the wording of this PR should be changed to something like this:
> 
> * Backporting JDK-8267189 as a prerequisite for JDK-8275731 (CDS archived enums objects are recreated at runtime)
> 
> You don't need to mention the other issues here. Instead, those issue should be listed in JDK-8275731:
> 
> * Add label jdk17u-fix-reques to JDK-8275731
> * Add a comment in JDK-8275731, with something like
>   * In order to backport this issue to jdk 17u, the following issues must be backported first, in the order of
>     1.  JDK-8267189: Remove duplicated unregistered classes from dynamic archive
>      2. JDK-XXXXXXX: xxxxxx
>      3. JDK-XXXXXXX: xxxxxx
>      4. JDK-XXXXXXX: xxxxxx
> 
> You should reach an agreement with the jdk17u maintainers first. I would suggest sending mail to the jdk-updates-dev mailing list. See https://mail.openjdk.org/pipermail/jdk-updates-dev/
> 
> You listed JDK-8270489 (Support archived heap objects in EpsilonGC) as a prerequisite, but that's a very large change and seems unrelated to the enum problem. More discussion is needed on jdk-updates-dev to decide which set of issues should be backported.

Hi @iklam 

Thanks for your teaching!

> I think the wording of this PR should be changed to something like this:

Updated.

> You don't need to mention the other issues here. Instead, those issue should be listed in JDK-8275731

Added.

> You should reach an agreement with the jdk17u maintainers first. I would suggest sending mail to the jdk-updates-dev mailing list.

May I just follow the [existing thread](https://mail.openjdk.org/pipermail/jdk-updates-dev/2022-December/019077.html) or create a new thread?

> You listed JDK-8270489 (Support archived heap objects in EpsilonGC) as a prerequisite, but that's a very large change and seems unrelated to the enum problem

Yes, there is a very large change, and owing to it requires `is_fully_available`:

The first commit about `HeapShared::is_fully_available` is for JDK-8270489: Support archived heap objects in EpsilonGC.
And the latest commit about `ArchiveHeapLoader::is_fully_available` is for JDK-8293293: Move archive heap loading code out of heapShared.cpp.

> More discussion is needed on jdk-updates-dev to decide which set of issues should be backported.

Yes!

Thanks,
Leslie Zhai

-------------

PR: https://git.openjdk.org/jdk17u-dev/pull/939