[jdk11u-dev] RFR: 8296904: Improve handling of macos xcode toolchain
Matthias Baesken
mbaesken at openjdk.org
Wed Dec 14 08:10:00 UTC 2022
On Sun, 11 Dec 2022 20:38:38 GMT, Christoph Langer <clanger at openjdk.org> wrote:
> This is a backport of JDK-8296904. Changes to make/autoconf/basic.m4 from jdk17u-dev apply cleanly.
> I resolved building.md to the state of jdk11u-dev and regenerated the html files with Pandoc 2.3.1. This also modified testing.html.
looks like we test in basic.m4 for DEVKIT_ROOT in the if check, but we do not use it afterwards and go directly to UTIL_LOOKUP_PROGS using TOOLCHAIN_PATH.
This seems to be different in head
https://github.com/openjdk/jdk/blob/470f3424fcce0e41b75cccdd5e3a56771cd07ff5/make/autoconf/basic.m4#L137
but on the other hand we do it in 17u-dev the same way. So probably the backport is okay, but maybe not optimal (comparing to head) ?
-------------
PR: https://git.openjdk.org/jdk11u-dev/pull/1584
More information about the jdk-updates-dev
mailing list