[jdk11u-dev] RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v8]
Vladimir Kempik
vkempik at openjdk.java.net
Tue Feb 8 10:29:07 UTC 2022
On Sat, 5 Feb 2022 15:30:59 GMT, Vladimir Kempik <vkempik at openjdk.org> wrote:
>> Initial version of JEP-391 backport to jdk11u.
>> Build system changes are mostly clean, except cds disabling part, it's copy&paste from aix part.
>> Things needing attention: os_bsd_aarch64.cpp and W^X transitions.
>> serviceability agent is mostly clean.
>> This passed GHA_tier1 testing.
>> Full regression testing is running now on Azul's infra, will report/update PR when done.
>> **Update: TCK passed, full regression testing is fine on intel platforms, macos/aarch64/openjdk11 is good compared to macos/aarch64/zulu11**
>> Sharing this PR slightly earlier to let other interested parties to run the tests too.
>> Example of cross-building on intel mac (needs Xcode12/13):
>> sh configure --with-boot-jdk=/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home/ --with-build-jdk=/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home/ --disable-warnings-as-errors --openjdk-target=aarch64-apple-darwin --with-extra-cflags='-arch arm64' --with-extra-ldflags='-arch arm64' --with-extra-cxxflags='-arch arm64'
>
> Vladimir Kempik has updated the pull request incrementally with one additional commit since the last revision:
>
> Add two missing WX transitions
These three line changes are part of jep-388 (win-arm64) backport to jdk11u-dev, they cause troubles ( warnings which are under Werror becomes an issue)
these changes aren't present in upstream (jdk19), for example - https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp#L1316
so I wonder why did they became part of jep-388 backport to jdk11u-dev
if there is no good reason, then I would like to revert these changes as part of this PR.
-------------
PR: https://git.openjdk.java.net/jdk11u-dev/pull/715
More information about the jdk-updates-dev
mailing list