[jdk11u-dev] RFR: 8133713: [macosx] Accessible JTables always reported as empty

[Martin Doerr]

On Thu, 19 May 2022 13:03:12 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> Backport of [JDK-8133713](https://bugs.openjdk.java.net/browse/JDK-8133713)
>> Required adaptation for JNF removal ([JDK-8257852](https://bugs.openjdk.java.net/browse/JDK-8257852)):
>> Definition and usage of `jm_getTableInfo` in JavaComponentAccessibility.m.
>> With this change, VoiceOver works for JTableAccessible.java (attached to JBS issue). Failed without this change.
>
> src/java.desktop/macosx/native/libawt_lwawt/awt/JavaComponentAccessibility.m line 2026:
> 
>> 2024:     jint count = (*env)->CallStaticIntMethod(env, jm_getTableInfo, fAccessible,
>> 2025:                                              fComponent, info);
>> 2026:     CHECK_EXCEPTION();
> 
> I'm not sure you need this exception check, but it does no harm so it might be better to leave it as-is.

The check is usually added when replacing the JNF calls (see other usages of CallStaticIntMethod). I also think it's better to have it even though the method should usually not throw any Exceptions. Thanks for the review!

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/1097