[jdk11u-dev] RFR: 8273553: sun.security.ssl.SSLEngineImpl.closeInbound also has similar error of JDK-8253368 [v2]
Goetz Lindenmaier
goetz at openjdk.org
Thu Oct 13 16:48:55 UTC 2022
On Thu, 13 Oct 2022 16:32:48 GMT, Martin Balao <mbalao at openjdk.org> wrote:
>> Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Add try ... finally.
>
> Thanks @GoeLin for proposing this backport. Looks good to me.
>
> I think that calling `conContext.closeInbound` as part of the finally block is right. I also prefer that refactorings related to fibers are done separately -if it's ever decided to backport them, which I doubt.
>
> One very minor detail (optional): there is an extra space in "throw new SSLException". The only reason I might fix this is to grep text easier. I'd also indent the line below 8 spaces.
Hi @martinuy, thanks for looking at this!
-------------
PR: https://git.openjdk.org/jdk11u-dev/pull/1422
More information about the jdk-updates-dev
mailing list