[jdk17u-dev] Integrated: 8300079: SIGSEGV in LibraryCallKit::inline_string_copy due to constant NULL src argument
Goetz Lindenmaier
goetz at openjdk.org
Thu Apr 27 10:35:24 UTC 2023
On Wed, 26 Apr 2023 07:47:56 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:
> I backport this for parity with 17.0.8-oracle.
>
> Does not apply because
> "8275201: C2: hide klass() accessor from TypeOopPtr and typeKlassPtr subclasses" is not in 17.
>
> The problem fixed by this change is that isa_aryptr() can return NULL.
> I checked all occurances of this call. Many of them are checked for NULL which
> was missing in head before this fix. For inline_string_copy() the check was missing
> in 17.
> For many of the other checks, the result is assigned to a variable and then checked,
> but then isa_aryptr() is called again. I changed the code to use the checked variable.
> I hope this makes clear that the check may not be removed :)
This pull request has now been integrated.
Changeset: 52324b55
Author: Goetz Lindenmaier <goetz at openjdk.org>
URL: https://git.openjdk.org/jdk17u-dev/commit/52324b55fb7be2cd1ba9e843ece93375ac23649c
Stats: 87 lines in 2 files changed: 61 ins; 0 del; 26 mod
8300079: SIGSEGV in LibraryCallKit::inline_string_copy due to constant NULL src argument
Reviewed-by: mdoerr
Backport-of: 45e4e00981ef8b4bf143afce0889698319273c1d
-------------
PR: https://git.openjdk.org/jdk17u-dev/pull/1297
More information about the jdk-updates-dev
mailing list