[jdk17u-dev] RFR: 8313816: Accessing jmethodID might lead to spurious crashes

[Jaroslav Bachorik]

On Fri, 1 Dec 2023 21:54:36 GMT, Paul Hohensee <phh at openjdk.org> wrote:

>> Reviewed-by: coleenp
>> 
>> A minor update required for the backport - the original changeset is using `nullptr` while the JDK 17 version is using `NULL`
>> 
>> Attaching the conflicting file for posterity.
>> 
>> [instanceKlass.cpp](https://github.com/openjdk/jdk17u-dev/files/13504341/InstanceKlass_conflict.txt)
>> 
>> Additionally,  I had to bring in a few test support classes as well - https://github.com/openjdk/jdk17u-dev/pull/2001/commits/d59ac82d5b4d3cace38e38cb7747642aaee98ba4
>
> Looks like a clean backport from the 17u PR, except for replacing nullptr with NULL as you note, and the unused declaration of metaspaceSharedRegionAlignment in WhiteBox.java. The latter doesn't seem have a definition in 11u: if so, please remove it.

@phohensee I think your last comment was supposed to go to https://github.com/openjdk/jdk11u-dev/pull/2321 

I checked for the addition of `metaspaceSharedRegionAlignment` in this PR and the method is already there, so I think you were really talking about the 11u backport PR.

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2001#issuecomment-1838249594