[jdk17u-dev] RFR: 8318183: C2: VM may crash after hitting node limit

Paul Hohensee phh at openjdk.org
Tue Dec 12 22:09:31 UTC 2023


On Mon, 11 Dec 2023 20:03:43 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> Semi-clean backport to solve a potential VM crash due to C2 failing.
> 
> The uncleanliness comes from two places:
> 
>  1. In `Compile::Optimize()`, we do not have the new hunk from [JDK-8286104](https://bugs.openjdk.org/browse/JDK-8286104):  https://github.com/openjdk/jdk/commit/31e50f2c7642b046dc9ea1de8ec245dcbc4e1926#diff-f076857d7da81f56709da3de1511b1105727032186cde4d02c678667761f46eaR2247-R2248 -- so no return is needed.
>  2. In `PhaseIdealLoop::verify`, we do not have the rewrites from [JDK-8173709](https://bugs.openjdk.org/browse/JDK-8173709): https://github.com/openjdk/jdk/commit/24c6af0637631153707615932f1f10ced4e5c0e8#diff-d49652d43244d52415873c37bf6990269b0d6e2f2111f4f971660470b6bca738R4653-R4657 -- so I had to resolve the conflict by hand.
> 
> Additional testing:
>  - [x] Linux x86_64 server fastdebug `tier{1,2,3}`
>  - [x] Linux AArch64 server fastdebug `tier{1,2,3}`

Marked as reviewed by phh (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk17u-dev/pull/2044#pullrequestreview-1778516906


More information about the jdk-updates-dev mailing list