[jdk11u-dev] RFR: 8229147: Linux os::create_thread() overcounts guardpage size with newer glibc (>=2.27) [v3]

[Thomas Stuefe]

On Thu, 20 Jul 2023 14:29:10 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:

>> This backport is for parity with 11.0.21-oracle. 
>> Fix didn't apply at all, os/linux/os_linux.cpp was too different in particular. 
>> I managed to create a working version by massaging and applying the changes manually. 
>> 
>> There is some risk involved. It is not caused by the intentional change of behavior but by potential collateral damage. 
>> 
>> Tests (SAP nightly test suite) do not indicate any issues.
>> Reviews pending.
>
> Lutz Schmidt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JDK-8229147 follow request from GoeLin

Looks good!

src/hotspot/os/linux/os_linux.cpp line 912:

> 910: 
> 911: // Dummy decl as substitute for cmdline parameter. TLS not in jdk11.
> 912: static const bool AdjustStackSizeForTLS = false;

Nit: could even be constexpr.

-------------

Marked as reviewed by stuefe (Reviewer).

PR Review: https://git.openjdk.org/jdk11u-dev/pull/2035#pullrequestreview-1540479109
PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2035#discussion_r1270239011