[jdk11u-dev] RFR: 8229147: Linux os::create_thread() overcounts guardpage size with newer glibc (>=2.27) [v3]

[Lutz Schmidt]

On Fri, 21 Jul 2023 05:28:34 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Lutz Schmidt has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   JDK-8229147 follow request from GoeLin
>
> src/hotspot/os/linux/os_linux.cpp line 912:
> 
>> 910: 
>> 911: // Dummy decl as substitute for cmdline parameter. TLS not in jdk11.
>> 912: static const bool AdjustStackSizeForTLS = false;
> 
> Nit: could even be constexpr.

This is just personal preference: I'd like to keep the integrated fix close to the original. I understand the KISS approach, though. It's just that I'm biased a bit more to the other side this time. 

Very important: thank you for the discussion and for the reviews!

-------------

PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2035#discussion_r1270541658