[jdk11u-dev] RFR: 8229348: java/net/DatagramSocket/UnreferencedDatagramSockets.java fails intermittently

[Goetz Lindenmaier]

On Thu, 1 Jun 2023 08:57:25 GMT, luchenlin <duke at openjdk.org> wrote:

> I backport this for parity with 11.0.20-oracle.
> No risk, only a test change.
> Tests pass. SAP nightly testing passed.

Only differences in context, code applied unchanged.

Marking reviewed assuming you'll fix the trivial issues.

test/jdk/java/net/DatagramSocket/UnreferencedDatagramSockets.java line 98:

> 96:                 buffer[0] += 1;
> 97:                 ss.send(p);         // send back +1
> 98:                 latch.await(); // wait for the client to receive the packet

Please remove the empty line as does the original change.
If we get such things right, later backports have a better chance to be clean.

test/jdk/java/net/DatagramSocket/UnreferencedDatagramSockets.java line 141:

> 139:         client.receive(p);
> 140:         svr.latch.countDown(); // unblock the server
> 141: 

Please add a second empty line as does the original change.

-------------

Marked as reviewed by goetz (Reviewer).

PR Review: https://git.openjdk.org/jdk11u-dev/pull/1922#pullrequestreview-1476305591
PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/1922#discussion_r1227567359
PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/1922#discussion_r1227568494