[jdk11u-dev] RFR: 8229348: java/net/DatagramSocket/UnreferencedDatagramSockets.java fails intermittently [v2]

[luchenlin]

On Tue, 13 Jun 2023 05:58:50 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> luchenlin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix the trivial issues
>
> test/jdk/java/net/DatagramSocket/UnreferencedDatagramSockets.java line 98:
> 
>> 96:                 buffer[0] += 1;
>> 97:                 ss.send(p);         // send back +1
>> 98:                 latch.await(); // wait for the client to receive the packet
> 
> Please remove the empty line as does the original change.
> If we get such things right, later backports have a better chance to be clean.

fixed

> test/jdk/java/net/DatagramSocket/UnreferencedDatagramSockets.java line 141:
> 
>> 139:         client.receive(p);
>> 140:         svr.latch.countDown(); // unblock the server
>> 141: 
> 
> Please add a second empty line as does the original change.

fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/1922#discussion_r1227590079
PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/1922#discussion_r1227590152