[jdk11u-dev] RFR: 8229912: [TESTBUG] java/net/Socks/SocksIPv6Test fails without IPv6

[Goetz Lindenmaier]

On Fri, 9 Jun 2023 05:41:31 GMT, luchenlin <duke at openjdk.org> wrote:

> I backport this for parity with 11.0.20-oracle.

LGTM. Probably clean.

test/jdk/java/net/Socks/SocksIPv6Test.java line 123:

> 121:     @Test(groups = "unit")
> 122:     public void testSocksOverIPv6() throws Exception {
> 123:         if (!shouldRun) return;

Please remove empty line as in orig change.

test/jdk/java/net/Socks/SocksIPv6Test.java line 139:

> 137:     @Test(groups = "unit")
> 138:     public void testSocksOverIPv6Hostname() throws Exception {
> 139:         if (!shouldRun) return;

Please also remove empty line.

-------------

Marked as reviewed by goetz (Reviewer).

PR Review: https://git.openjdk.org/jdk11u-dev/pull/1939#pullrequestreview-1476369248
PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/1939#discussion_r1227606105
PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/1939#discussion_r1227606968