[jdk11u-dev] RFR: 8229912: [TESTBUG] java/net/Socks/SocksIPv6Test fails without IPv6 [v2]

[luchenlin]

On Tue, 13 Jun 2023 06:43:47 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> luchenlin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix the trivial issues
>
> test/jdk/java/net/Socks/SocksIPv6Test.java line 123:
> 
>> 121:     @Test(groups = "unit")
>> 122:     public void testSocksOverIPv6() throws Exception {
>> 123:         if (!shouldRun) return;
> 
> Please remove empty line as in orig change.

fixed

> test/jdk/java/net/Socks/SocksIPv6Test.java line 139:
> 
>> 137:     @Test(groups = "unit")
>> 138:     public void testSocksOverIPv6Hostname() throws Exception {
>> 139:         if (!shouldRun) return;
> 
> Please also remove empty line.

fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/1939#discussion_r1227613411
PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/1939#discussion_r1227613520