[jdk11u-dev] RFR: 8293562: KeepAliveCache Blocks Threads while Closing Connections [v2]

[Severin Gehwolf]

On Tue, 30 May 2023 10:57:13 GMT, PoojaDP-23 <duke at openjdk.org> wrote:

>> fix: https://bugs.openjdk.org/browse/JDK-8293562
>
> PoojaDP-23 has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge branch 'master' into keep-alive
>  - address  whitespace error
>    
>    Signed-off-by: Pooja.D.P <Pooja.D.P1 at ibm.com>
>  - Address indentation
>    
>    Signed-off-by: Pooja.D.P <Pooja.D.P1 at ibm.com>
>  - Backport 454ef9ba2b2b15250a29251556f79a0464df5ccc
>    
>    Signed-off-by: Pooja.D.P <Pooja.D.P1 at ibm.com>

This seems OK to me. A few minor comments. What testing have you done?

src/java.base/share/classes/sun/net/www/http/KeepAliveCache.java line 293:

> 291: }
> 292: 
> 293:  /* LIFO order for reusing HttpClients. Most recent entries at the front.

Nit: Extraneous space in front of `/*`.

test/jdk/sun/net/www/http/KeepAliveCache/B8293562.java line 138:

> 136:                 }
> 137:             } else {
> 138:                 System.out.println("name of the thread" +threadName);

This isn't part of the original change. Please remove.

test/jdk/sun/net/www/http/KeepAliveCache/B8293562.java line 143:

> 141:             }
> 142:             System.out.println("Connection closed");
> 143:             System.out.println(threadName);

Same here. Extraneous debug `println()`?

-------------

PR Review: https://git.openjdk.org/jdk11u-dev/pull/1890#pullrequestreview-1476663920
PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/1890#discussion_r1227802749
PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/1890#discussion_r1227808218
PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/1890#discussion_r1227809485