[jdk11u-dev] RFR: 8242151: Improve OID mapping and reuse among JDK security providers for aliases registration [v3]

[Martin Balao]

On Tue, 13 Jun 2023 13:39:22 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

> > In sun/security/util/ConstraintsParameters.java:
> > If there weren't any changes to the file, we should probably keep the current copyright date in the header.
> 
> We usually always backport the Copyrights and resolve to the later year if necessary. This file should have been edited by this change, but the edit was made in 8249906 which forgot to adapt the Copyright. So I would like adapt this now here.

Ah, good.

> > In sun/security/util/ObjectIdentifier.java:
> > Is it possible to remove "public ObjectIdentifier(int[] values)" and "public static ObjectIdentifier newInternal(int[] values)" now? This could be part of 8239264 backport perhaps. This will make help to check that there are no current uses and enforce that it's not used in the future.
> 
> I removed it before. Build and tests pass without it. But Matthias asked me to add it again to not break compatibility.
>

Hmm, I tend to agree with your initial decision but ok. This is an internal API (based on the package). It's good to know that no one internally is currently using it. My only concern is that someone in the future does, if we keep it available. Anyways, let's move on.

-------------

PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1908#issuecomment-1589548544