[jdk17u-dev] RFR: 8272586: emit abstract machine code in hs-err logs
Martin Doerr
mdoerr at openjdk.org
Mon Jun 19 13:17:46 UTC 2023
Backport of JDK-8272568 with follow-up fixes (see Commits).
This PR contains the following commits:
1. [JDK-8272586](https://bugs.openjdk.org/browse/JDK-8272586): emit abstract machine code in hs-err logs
This is the main part. Almost clean. Code move had to be done manually because `JavaThread::cast(t)` was introduced after JDK17. (JDK17 uses `t->as_Java_thread()`.)
2. [JDK-8275031](https://bugs.openjdk.org/browse/JDK-8275031): runtime/ErrorHandling/MachCodeFramesInErrorFile.java fails when hsdis is present
Small fix. Clean.
3. [JDK-8277102](https://bugs.openjdk.org/browse/JDK-8277102): Dubious PrintCompilation output
Basically reverts the timestamp change. Clean.
I'm planning to backport the other follow-up changes separately:
1. [JDK-8274986](https://bugs.openjdk.org/browse/JDK-8274986): max code printed in hs-err logs should be configurable
Clean but replacement of `JavaThread::cast` is needed.
2. [JDK-8283056](https://bugs.openjdk.org/browse/JDK-8283056): show abstract machine code in hs-err for all VM crashes
Clean.
The feature greatly helps analyzing VM crashes.
-------------
Commit messages:
- Backport 2f0bde1a658b0910304c110920a2e8ccbe4557f8
- Backport a5f09d1088d9dd610139370739e9fbd6e34416cb
- Backport b60837a7d5d6f920d2fb968369564df155dc1018
Changes: https://git.openjdk.org/jdk17u-dev/pull/1446/files
Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1446&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8272586
Stats: 348 lines in 6 files changed: 304 ins; 20 del; 24 mod
Patch: https://git.openjdk.org/jdk17u-dev/pull/1446.diff
Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1446/head:pull/1446
PR: https://git.openjdk.org/jdk17u-dev/pull/1446
More information about the jdk-updates-dev
mailing list