[jdk11u-dev] RFR: 8262981: Create implementation for NSAccessibilitySlider protocol [v2]

Sergey Bylokhov serb at openjdk.org
Fri Mar 17 21:35:27 UTC 2023


On Fri, 17 Mar 2023 20:42:40 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> I propose to backport JDK-8262981 in a way that does not require a CSR. Just integrate the native code but don't touch the Java interface of javax.swing.JSlider.
>
> Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:
> 
>   Backport 9d669c912d3977027f321a5e6b7f045ca2ce9482

src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/SliderAccessibility.m line 52:

> 50: - (BOOL)accessibilityPerformDecrement
> 51: {
> 52:     return [self performAccessibleAction:DECREMENT];

This method should upcall the java part of the patch, and may throw an exception if we will skip it.

I think we should include the java part but make it private, then re-implement this next code path to call it:
accessibilityPerformDecrement->performAccessibleAction:->CAccessibility#doAccessibleAction()->JSlider

-------------

PR: https://git.openjdk.org/jdk11u-dev/pull/1811


More information about the jdk-updates-dev mailing list