[jdk11u-dev] RFR: 8262981: Create implementation for NSAccessibilitySlider protocol [v2]

Christoph Langer clanger at openjdk.org
Sat Mar 18 21:19:33 UTC 2023


On Fri, 17 Mar 2023 21:32:31 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
>> 
>>   Backport 9d669c912d3977027f321a5e6b7f045ca2ce9482
>
> src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/SliderAccessibility.m line 52:
> 
>> 50: - (BOOL)accessibilityPerformDecrement
>> 51: {
>> 52:     return [self performAccessibleAction:DECREMENT];
> 
> This method should upcall the java part of the patch, and may throw an exception if we will skip it.
> 
> I think we should include the java part but make it private, then re-implement this next code path to call it:
> accessibilityPerformDecrement->performAccessibleAction:->CAccessibility#doAccessibleAction()->JSlider

You're right, that's a good catch. We'll need to rework that. performAccessibleAction, however, will expect an AccessibleAction, so we need to do this differently, if we can't implement this interface in JSlider.

-------------

PR: https://git.openjdk.org/jdk11u-dev/pull/1811


More information about the jdk-updates-dev mailing list