[jdk11u] RFR: 8304389: [11u] Crash on Windows in C2 compiled code after 8248238 and 8218431

Goetz Lindenmaier goetz at openjdk.org
Tue Mar 21 07:52:48 UTC 2023


On Fri, 17 Mar 2023 07:47:44 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

> … 8218431
> 
> A required fix to avoid regression in 11.0.19. See JBS issue.

Hi
I pushed a new change.  #if 0 is not supported by adlc, therefore #ifdef WRONG

> My concern with just changing just the .ad file is there are other uses of #ifdef _WIN64 in x86 .hpp header files that adlc files might include directly or indirectly.

adlc reads the ad file, evaluates the _WIN64, swallows it and outputs C++ files without that define.
The C++ build compiling the generated files has _WIN64 set anyways, already before the trouble we look at here.

-------------

PR Comment: https://git.openjdk.org/jdk11u/pull/70#issuecomment-1477399647


More information about the jdk-updates-dev mailing list