[jdk17u-dev] RFR: 8273522: Rename test property vm.cds.archived.java.heap to vm.cds.write.archived.java.heap

[Lutz Schmidt]

On Mon, 18 Sep 2023 07:49:58 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

> I backport this to simplify backport of tests that use the new property name.
> 
> Resolves were simple, only the method checking the flags set does not match good:
> 
> src/hotspot/share/cds/heapShared.hpp
> Skipped. is_heap_object_archiving_allowed(), the predecessor of can_write(), does not have this assertion.
> 
> src/hotspot/share/prims/whitebox.cpp
> I had to adapt this.
> In 17, method is_heap_object_archiving_allowed() is called in WB_IsJavaHeapArchiveSupported()
> Between 17 and 18, this has been renamed to can_write().
> Also, WB_IsJavaHeapArchiveSupported() has been changed to call can_use(),
> where this change reverts this to call can_write().
> So I leave the call as-is, this shows the desired behaviour.
> 
> test/hotspot/jtreg/runtime/cds/SharedStrings.java
> test/hotspot/jtreg/runtime/cds/appcds/cacheObject/ArchivedModuleWithCustomImageTest.java
> test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/FlagCombo.java
> test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/InternSharedString.java
> test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/LargePages.java
> test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/LockSharedStrings.java
> test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/SharedStringsBasicPlus.java
> test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/SharedStringsWbTest.java
> test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/SysDictCrash.java
> test/hotspot/jtreg/runtime/cds/serviceability/ReplaceCriticalClassesForSubgraphs.java
> test/lib/jdk/test/whitebox/WhiteBox.java
> Trivial resolves of the property.
> 
> test/lib/sun/hotspot/WhiteBox.java: No such file or directory
> Skipped, was merged with the other WhiteBox.

Looks good.
Did you run tests in addition to GHA?

-------------

Marked as reviewed by lucy (Reviewer).

PR Review: https://git.openjdk.org/jdk17u-dev/pull/1748#pullrequestreview-1637478883