[jdk11u-dev] RFR: 8263940: NPE when creating default file system when default file system provider is packaged as JAR file on class path

[Amos Shi]

On Thu, 25 Apr 2024 08:38:15 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> src/java.base/share/classes/java/util/zip/ZipFile.java line 1410:
>> 
>>> 1408:                         return false;
>>> 1409:                     }
>>> 1410:                     if (!attrs.lastModifiedTime().equals(key.attrs.lastModifiedTime())) {
>> 
>> The `private static class Key` class does not have the `ZipCoder zc` constructor parameter, here we add it based on current latest code in https://github.com/openjdk/jdk/
>
> The backported change does not add the zc argumenht to the call in lin 1436.
> Can you please explain why you add it?  Originally it was added for larger change JDK-8243254

Hi @GoeLin , 
- Because in the Line `1436` of the same file, it needs the 3rd parameter `zc` . 
  - Without this parameter, there will be a compile error. 


1436    BasicFileAttributes.class), zc);


- Considering this is an internal `private` class (line `1385`)
  - So we can add this parameter more safely.


1385    private static class Key {

-------------

PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2647#discussion_r1579690389