[jdk11u-dev] RFR: 8263940: NPE when creating default file system when default file system provider is packaged as JAR file on class path

[Goetz Lindenmaier]

On Fri, 26 Apr 2024 08:34:05 GMT, Amos Shi <ashi at openjdk.org> wrote:

>> Yes, but it is you who added the paramteter zc in line 1436, not the patch you backported. 
>> The backported patch only `adds builtInFS.getPath()` and changes the line breaks.
>> So why did you add zc in line 1436? I think you should not add it there, and then you don't need the other additional changes either.
>
> @GoeLin ,
> 
> Yes, in the diff the `zc` was not added.
> 
> Well because in the original commit https://github.com/openjdk/jdk/commit/717792c3b728584413572e7aede83290779be2a2 , the `zc` parameter exits in the base line already. so in `jdk11u-dev` we were trying to keep in line with the latest code base.

Ok, if the reason is only to get 11 closer to 17, I think it is better to remove zc at the call site and in the callee from this change here.  The code belongs to [JDK-8243254](https://bugs.openjdk.org/browse/JDK-8243254), but that change is an enhancement and quite large, so it's not a good candidate for backporting.
Here we just want to fix the bug addressed.

-------------

PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2647#discussion_r1580745753