[jdk11u-dev] RFR: 8263940: NPE when creating default file system when default file system provider is packaged as JAR file on class path

[Amos Shi]

On Fri, 26 Apr 2024 05:53:58 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> Hi @GoeLin , 
>> - Because in the Line `1436` of the same file, it needs the 3rd parameter `zc` . 
>>   - Without this parameter, there will be a compile error. 
>> 
>> 
>> 1436    BasicFileAttributes.class), zc);
>> 
>> 
>> - In the latest `jdk` code, the 3d parameter `zc` has been there already
>>   - Well in `jdk11u-dev`, the parameter was not there yet
>> 
>> - Considering this is an internal `private` class (line `1385`)
>>   - So we can add this parameter more safely with current Jira ticket.
>> 
>> 
>> 1385    private static class Key {
>
> Yes, but it is you who added the paramteter zc in line 1436, not the patch you backported. 
> The backported patch only `adds builtInFS.getPath()` and changes the line breaks.
> So why did you add zc in line 1436? I think you should not add it there, and then you don't need the other additional changes either.

@GoeLin ,

Yes, in the diff the `zc` was not added.

Well because in the original commit https://github.com/openjdk/jdk/commit/717792c3b728584413572e7aede83290779be2a2 , the `zc` parameter exits in the base line already. so in `jdk11u-dev` we were trying to keep in line with the latest code base.

-------------

PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2647#discussion_r1580679134