[jdk17u-dev] RFR: 8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used [v4]

[Amos Shi]

On Mon, 29 Apr 2024 15:54:17 GMT, Sonia Zaldana Calles <szaldana at openjdk.org> wrote:

>> Hi all, 
>> 
>> This PR contains a backport of [43c6f0b5880899b797fab2f851bd35be1c342439](https://github.com/openjdk/jdk/commit/43c6f0b5880899b797fab2f851bd35be1c342439). 
>> 
>> Patch is not clean. Test won't build in 17 because it can't find ```import jdk.internal.util.OperatingSystem```.
>> 
>> This class was introduced in 21 as part of [JDK-8303485](https://bugs.openjdk.org/browse/JDK-8303485).
>> 
>> I've worked around that by removing the dependency to that utility function and checking the operating system with ```test/lib/jdk/test/lib/Platform.java```.
>> 
>> Testing: 
>> - [x] Modified test case passes 
>> 
>> Thanks!
>
> Sonia Zaldana Calles has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Using test/lib/jdk/test/lib/Platform.java instead of System.getProperty

SAP nightlies passed on `2024-05-01`
- Automated jtreg test: jtreg_jdk_tier1
- `jdk/modules/etc/JmodExcludedFiles.java`: **SUCCESSFUL** GitHub 📊⏲ - [526 msec]

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2321#issuecomment-2086698066