[jdk17u-dev] RFR: 8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used [v4]

Sonia Zaldana Calles szaldana at openjdk.org
Mon Apr 29 15:54:17 UTC 2024


> Hi all, 
> 
> This PR contains a backport of [43c6f0b5880899b797fab2f851bd35be1c342439](https://github.com/openjdk/jdk/commit/43c6f0b5880899b797fab2f851bd35be1c342439). 
> 
> Patch is not clean. Test won't build in 17 because it can't find ```import jdk.internal.util.OperatingSystem```.
> 
> This class was introduced in 21 as part of [JDK-8303485](https://bugs.openjdk.org/browse/JDK-8303485).
> 
> I've worked around that by removing the dependency to that utility function and checking the operating system with ```test/lib/jdk/test/lib/Platform.java```.
> 
> Testing: 
> - [x] Modified test case passes 
> 
> Thanks!

Sonia Zaldana Calles has updated the pull request incrementally with one additional commit since the last revision:

  Using test/lib/jdk/test/lib/Platform.java instead of System.getProperty

-------------

Changes:
  - all: https://git.openjdk.org/jdk17u-dev/pull/2321/files
  - new: https://git.openjdk.org/jdk17u-dev/pull/2321/files/d6349c50..4f9ce06c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2321&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2321&range=02-03

  Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk17u-dev/pull/2321.diff
  Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2321/head:pull/2321

PR: https://git.openjdk.org/jdk17u-dev/pull/2321


More information about the jdk-updates-dev mailing list