[jdk17u-dev] Integrated: 8306929: Avoid CleanClassLoaderDataMetaspaces safepoints when previous versions are shared

[Oli Gillespie]

On Fri, 2 Aug 2024 13:20:38 GMT, Oli Gillespie <ogillespie at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [408cec51](https://github.com/openjdk/jdk/commit/408cec516bb5fd82fb6dcddeee934ac0c5ecffaf) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
> 
> The commit being backported was authored by Stefan Johansson on 4 May 2023 and was reviewed by Coleen Phillimore and Serguei Spitsyn.
> 
> It's clean except for the surrounding context changing between NULL and nullptr which was trivial to resolve. It comes with its own test, but I also confirmed that it fixes the reproducer shared on the issue.
> 
> Edit: This now also backports 8307448/https://github.com/openjdk/jdk/commit/29233e0a001adde71a3fa5d56292ccfba8409ea5 to fix the flaky test. 8307448 applied cleanly.
> 
> Testing - looks good, just 3 unrelated tests failing on my machine.
> 
> 
>  JTREG_KEYWORDS="!headful & !external-dep & !printer" make test TEST=all
> 
>    TEST                                              TOTAL  PASS  FAIL ERROR
>    jtreg:test/hotspot/jtreg:all                       6131  6131     0     0
>>> jtreg:test/jdk:all                                 9140  9137     3     0 <<
>    jtreg:test/langtools:all                           4251  4251     0     0
>    jtreg:test/jaxp:all                                 467   467     0     0
>    jtreg:test/lib-test:all                              30    30     0     0
>    
> build/AbsPathsInImage.java                                                                                         Failed. Execution failed: `main' threw exception: java.lang.Exception: Test failed
> java/nio/channels/FileChannel/directio/DirectIOTest.java                                                           Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: DirectIO is not working properly with read. File still exists in cache!
> jdk/internal/platform/docker/TestDockerMemoryMetrics.java                                                          Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: Expected to get exit value of [0]
> 
> 
> Thanks!

This pull request has now been integrated.

Changeset: 1f14f860
Author:    Oli Gillespie <ogillespie at openjdk.org>
Committer: Aleksey Shipilev <shade at openjdk.org>
URL:       https://git.openjdk.org/jdk17u-dev/commit/1f14f86087d4da6bad981f53f309e8d9da31f5d0
Stats:     148 lines in 6 files changed: 125 ins; 3 del; 20 mod

8306929: Avoid CleanClassLoaderDataMetaspaces safepoints when previous versions are shared
8307448: Test RedefineSharedClassJFR fail due to wrong assumption

Reviewed-by: shade
Backport-of: 408cec516bb5fd82fb6dcddeee934ac0c5ecffaf

-------------

PR: https://git.openjdk.org/jdk17u-dev/pull/2776