[jdk21u-dev] RFR: 8310683: Refactor StandardCharset/standard.java to use JUnit

Amos Shi ashi at openjdk.org
Thu Aug 8 20:29:05 UTC 2024


Backport of [JDK-8310683](https://bugs.openjdk.org/browse/JDK-8310683)
- This PR contains three commits
- `commit 1` is the `clean` backport of `Standard.java` file from [JDK-8310047](https://bugs.openjdk.org/browse/JDK-8310047), which is the dependency of current PR [JDK-8310683](https://bugs.openjdk.org/browse/JDK-8310683)
- `commit 2` is the `clean` backport of [JDK-8310683](https://bugs.openjdk.org/browse/JDK-8310683) original commit
- `commit 3` is fixing the compile error of the test case, to remove the charsets added by [JDK-8310047](https://bugs.openjdk.org/browse/JDK-8310047) in Java 22


/Users/I048686/SAPDevelop/github.com/dev-8310683-21/test/jdk/java/nio/charset/StandardCharsets/Standard.java:140: error: cannot find symbol
                Arguments.of(StandardCharsets.UTF_32BE, "UTF-32BE"),
                                             ^
  symbol:   variable UTF_32BE
  location: class StandardCharsets
/Users/I048686/SAPDevelop/github.com/dev-8310683-21/test/jdk/java/nio/charset/StandardCharsets/Standard.java:141: error: cannot find symbol
                Arguments.of(StandardCharsets.UTF_32LE, "UTF-32LE"),
                                             ^
  symbol:   variable UTF_32LE
  location: class StandardCharsets
/Users/I048686/SAPDevelop/github.com/dev-8310683-21/test/jdk/java/nio/charset/StandardCharsets/Standard.java:142: error: cannot find symbol
                Arguments.of(StandardCharsets.UTF_32, "UTF-32")
                                             ^
  symbol:   variable UTF_32
  location: class StandardCharsets


Testing
- Local: Test passed on `MacOS 14.6.1` on Apple M1 Max
  - `Standard.java`: Test results: passed: 1
- Pipeline: 
- Testing Machine:

-------------

Commit messages:
 - Backport d82ade354570a930d8282684a8ffd368c613defc Remove new fields by JDK-8310047
 - Backport d82ade354570a930d8282684a8ffd368c613defc
 - Backport 00c7f914c665a77842d32eb8f760dcbbbda66554

Changes: https://git.openjdk.org/jdk21u-dev/pull/903/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=903&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8310683
  Stats: 128 lines in 1 file changed: 49 ins; 28 del; 51 mod
  Patch: https://git.openjdk.org/jdk21u-dev/pull/903.diff
  Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/903/head:pull/903

PR: https://git.openjdk.org/jdk21u-dev/pull/903


More information about the jdk-updates-dev mailing list