[jdk21u-dev] RFR: 8322142: JFR: Periodic tasks aren't orphaned between recordings

Anton Hägerstrand duke at openjdk.org
Thu Jan 25 06:03:30 UTC 2024


On Wed, 24 Jan 2024 13:36:33 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Backport to fix https://bugs.openjdk.org/browse/JDK-8322142 for jdk21. 
>> 
>> First time commiting to openjdk, so please pardon if this is the wrong approach to the PR. I followed instructions in https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix - not sure if those are still valid for 21.
>
> The fix request comment didn't mention it so I'm removing the approval label for now. Please re-apply once that's present/fixed.

@jerboaa Thanks - I did run the tier1 suite locally before creating the PR. I also enabled GHA for the for the fork, but did that after creating the PR so I don't think that it automatically triggered - I now triggered a run which seems to have passed: https://github.com/antonha/jdk21u-dev/actions/runs/7646727789

I'm not that familiar with the test suite so I don't quite know which JFR tests there are, but I did now try running the `jdk/jfr` tests using `make run-test TEST=jdk/jfr` for `linux-x86_64-server-release` and `linux-x86_64-server-fastdebug` locally, both pass with the same message:


==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
   jtreg:test/jdk/jdk/jfr                              584   584     0     0   
==============================
TEST SUCCESS


Should I re-apply for approval now?

-------------

PR Comment: https://git.openjdk.org/jdk21u-dev/pull/203#issuecomment-1909408565


More information about the jdk-updates-dev mailing list