[jdk21u-dev] RFR: 8326332: Unclosed inline tags cause misalignment in summary tables [v3]

Ralf Schmelter rschmelter at openjdk.org
Thu Jul 25 11:22:36 UTC 2024


On Wed, 24 Jul 2024 12:47:50 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> Backport of 8326332
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove isEmpty check, we check already before

Looks good so far.

src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java line 1138:

> 1136: 
> 1137:     // helper methods because jdk21 functionality is not allowed
> 1138:     Name getLastHelper(List<Name> l) {

This could be made static and private.

-------------

Changes requested by rschmelter (Reviewer).

PR Review: https://git.openjdk.org/jdk21u-dev/pull/866#pullrequestreview-2199021571
PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/866#discussion_r1691277991


More information about the jdk-updates-dev mailing list