[jdk21u-dev] RFR: 8326332: Unclosed inline tags cause misalignment in summary tables [v3]

[Matthias Baesken]

On Thu, 25 Jul 2024 11:18:53 GMT, Ralf Schmelter <rschmelter at openjdk.org> wrote:

>> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove isEmpty check, we check already before
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java line 1138:
> 
>> 1136: 
>> 1137:     // helper methods because jdk21 functionality is not allowed
>> 1138:     Name getLastHelper(List<Name> l) {
> 
> This could be made static and private.

Agree,  'private static' this is better .

-------------

PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/866#discussion_r1691321954