[jdk11u-dev] RFR: 8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls
Andrew John Hughes
andrew at openjdk.org
Thu Jun 6 01:31:55 UTC 2024
On Fri, 31 May 2024 20:33:34 GMT, fitzsim <duke at openjdk.org> wrote:
> 8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls
>
> Reviewed-by: kbarrett, djelinski
> Backport-of: d7298245d6759f62e253b5cf0df975db17fdbf82
When backporting, it would be good if you could detail any changes you had to make to get the patch to apply and build on the new target.
>From comparing the 11u & 17u versions, the changes I see are:
1. Context difference in `make/autoconf/libraries.m4`
2. `NULL` vs `nullptr` in `src/hotspot/share/utilities/ostream.cpp`
3. Absence of [JDK-8265101](https://bugs.openjdk.org/browse/JDK-8265101) so `os::get_host_by_name` has to be removed from AIX, BSD, Linux and Solaris `os_<os>.inline.hpp` files rather than just `os_posix.cpp`
Assuming these changes tally with your experience, this seems fine to me.
-------------
Marked as reviewed by andrew (Reviewer).
PR Review: https://git.openjdk.org/jdk11u-dev/pull/2732#pullrequestreview-2100599690
More information about the jdk-updates-dev
mailing list