[jdk11u-dev] RFR: 8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls

[fitzsim]

On Thu, 6 Jun 2024 01:28:42 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> When backporting, it would be good if you could detail any changes you had to make to get the patch to apply and build on the new target.

Noted, will do from now on.

> From comparing the 11u & 17u versions, the changes I see are:
> 
>     1. Context difference in `make/autoconf/libraries.m4`
> 
>     2. `NULL` vs `nullptr` in `src/hotspot/share/utilities/ostream.cpp`
> 
>     3. Absence of [JDK-8265101](https://bugs.openjdk.org/browse/JDK-8265101) so `os::get_host_by_name` has to be removed from AIX, BSD, Linux and Solaris `os_<os>.inline.hpp` files rather than just `os_posix.cpp`
> 
> Assuming these changes tally with your experience, this seems fine to me.

Yes, that sounded right, and I just re-verified that the differences you mention are the only ones, by comparing this proposed patch to 11 with https://github.com/openjdk/jdk17u-dev/commit/4071b8c9be8e763d48bab1a5b8d57729a4f1307b.

Thank you for reviewing, @gnu-andrew.

-------------

PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2732#issuecomment-2151286926
PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2732#issuecomment-2151287599