[jdk11u-dev] RFR: 8292717: Clean up checking of testing requirements in configure
Aleksey Shipilev
shade at openjdk.org
Mon Mar 18 10:10:38 UTC 2024
On Tue, 12 Mar 2024 14:39:48 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:
> I backport this because then 8314495 can be backported clean. Also brings 11 closer to 17.
>
> configure.ac::
> I had to resolve two chunks. In one, I needed to omit the coding for JMH which is not
> supported by 11.
>
> jdk-options.m4, toolchanin.m4
> Deleted function has different body, deleted by hand.
>
> lib-tests.m4: Copyright.
>
> The original change moves and renames three
> functions to lib-tests.m4. It does not change
> the implementation of these.
> So I modified the added code in lib-tests.m4
> to have the unchanged function bodies that
> were deleted in the other files.
This looks fine, thanks. It is generally hard to check that we have not introduced bugs while doing these move, but as long as they are mostly mechanical, I think we are safer.
I don't see the `JTREG_MINIMUM_VERSION=6.1` hunk in the original commit (https://github.com/openjdk/jdk/commit/16593cf51c3d994ba4a6d28ab97e519dfd53f37b), but I guess we need to move it from `toolchain.m4` for 11u-dev.
-------------
Marked as reviewed by shade (Reviewer).
PR Review: https://git.openjdk.org/jdk11u-dev/pull/2600#pullrequestreview-1942507071
More information about the jdk-updates-dev
mailing list