[jdk11u-dev] RFR: 8292717: Clean up checking of testing requirements in configure

[Martin Doerr]

On Tue, 12 Mar 2024 14:39:48 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

> I backport this because then 8314495 can be backported clean. Also brings 11 closer to 17.
> 
> configure.ac::
> I had to resolve two chunks. In one, I needed to omit the coding for JMH which is not
> supported by 11.
> 
> jdk-options.m4, toolchanin.m4
> Deleted function has different body, deleted by hand.
> 
> lib-tests.m4: Copyright.
> 
> The original change moves and renames three
> functions to lib-tests.m4. It does not change
> the implementation of these.
> So I modified the added code in lib-tests.m4
> to have the unchanged function bodies that
> were deleted in the other files.

I think it's good. Feel free to add the empty line.

make/autoconf/configure.ac line 235:

> 233: 
> 234: JDKOPT_DETECT_INTREE_EC
> 235: LIB_TESTS_ENABLE_DISABLE_FAILURE_HANDLER

Original change inserts an empty line here.

make/autoconf/lib-tests.m4 line 31:

> 29: 
> 30: # Minimum supported version
> 31: JTREG_MINIMUM_VERSION=6.1

Moving the stuff here from the deleted file is probably ok.

-------------

Marked as reviewed by mdoerr (Reviewer).

PR Review: https://git.openjdk.org/jdk11u-dev/pull/2600#pullrequestreview-1942527935
PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2600#discussion_r1528264297
PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2600#discussion_r1528268158