[jdk17u-dev] RFR: 8276227: ciReplay: SIGSEGV if classfile for replay compilation is not present after JDK-8275868
Martin Doerr
mdoerr at openjdk.org
Wed Mar 27 15:23:27 UTC 2024
On Wed, 27 Mar 2024 09:12:20 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:
> I had to do a trivial resolve in ciReplay and adapt the path to WhiteBox in the test.
>
> Follow up for 8275868.
LGTM. Please consider inserting the empty line before integrating.
src/hotspot/share/ci/ciReplay.cpp line 696:
> 694: // in signatures of inlinees. This ensures that inlining can be done as stated in the replay file.
> 695: _protection_domain = Handle(_thread, k->protection_domain());
> 696: }
Original change inserts an empty line, here.
-------------
Marked as reviewed by mdoerr (Reviewer).
PR Review: https://git.openjdk.org/jdk17u-dev/pull/2335#pullrequestreview-1963675159
PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2335#discussion_r1541328403
More information about the jdk-updates-dev
mailing list