[jdk17u-dev] RFR: 8324243: Compilation failures in java.desktop module with gcc 14

[Martin Doerr]

On Thu, 16 May 2024 01:32:10 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:

>> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 473:
>> 
>>> 471:    HARFBUZZ_DISABLED_WARNINGS_CXX_gcc := reorder delete-non-virtual-dtor strict-overflow \
>>> 472:         maybe-uninitialized class-memaccess unused-result extra use-after-free noexcept-type \
>>> 473:         expansion-to-defined dangling-reference calloc-transposed-args
>> 
>> Can you include https://github.com/openjdk/jdk/commit/ec79ab4b3cd89c2c0a9c8550cd62433bd6d45266, please, such that the code looks like the upstream version?
>> And consider using "/issue add JDK-8319268". GCC8 should still be supported.
>
> I would like to backport it separately. The list of versions affected is different and moreover I do not have the problem reproducible. I have tried devtoolset-8-gcc-8.3.1-3.2.el7.x86_64 (CentOS-7) and gcc-8.3.0.tar.xz (rebuilt from source). I have tried to build this branch https://github.com/jankratochvil/jdk17u-dev/tree/8324243 .
> Filed as https://github.com/openjdk/jdk17u-dev/pull/2475 .

Even better. Thanks! This should make this backport clean and no longer require a review. And it will make future backports which touch this code clean, too.

-------------

PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2468#discussion_r1602870828