[jdk17u-dev] RFR: 8324243: Compilation failures in java.desktop module with gcc 14 [v2]

[Jan Kratochvil]

On Thu, 16 May 2024 08:32:04 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> I would like to backport it separately. The list of versions affected is different and moreover I do not have the problem reproducible. I have tried devtoolset-8-gcc-8.3.1-3.2.el7.x86_64 (CentOS-7) and gcc-8.3.0.tar.xz (rebuilt from source). I have tried to build this branch https://github.com/jankratochvil/jdk17u-dev/tree/8324243 .
>> Filed as https://github.com/openjdk/jdk17u-dev/pull/2475 .
>
> Even better. Thanks! This should make this backport clean and no longer require a review. And it will make future backports which touch this code clean, too.

Now it should look like: https://github.com/openjdk/jdk/commit/8e5f6ddb68572c0cc8b6e256e423706f6f7cec94
It was later reformatted a bit but that is a different patch: https://github.com/openjdk/jdk/commit/d292aabf05edf41e14eca1976142f63c7b54779e#diff-c75e2d581b3730cf900075cedb66ac72eaba40fbbd92eaac5710161830b572b4

-------------

PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2468#discussion_r1603239812