[jdk11u-dev] RFR: 8344458: [11u] Add initial support for building with XCode 14 [v2]

Antonio Vieiro duke at openjdk.org
Tue Nov 19 06:53:34 UTC 2024


> An implementation of [JDK-8344458](https://bugs.openjdk.org/browse/JDK-8344458) that adds conditional support for building on `macos` with `XCode 14` while keeping compatibility with previous `XCode` versions.
> 
> The PR is separated in three commits for easier review:
> 
> - First commit adds a new `--enable-xcode14` configuration flag (which is currently disabled in GHA) and two additional variables:
>     - `CFLAGS_XCODE14_DEPR_DECLARATIONS` (empty on current XCode versions, set to and `-Wno-deprecated-declarations` when `--enable-xcode14`is used)
>     - And `CFLAGS_XCODE14_DEPR_NON_PROTOTYPE` (empty on current XCode versions, set to `-Wno-deprecated-non-prototype` when `--enable-xcode14` is used).
> - The second commit applies `CFLAGS_XCODE14_DEPR_DECLARATIONS` to those parts of the codebase that use the deprecated `sprintf` function (i.e., avoiding `sprintf` usage errors in XCode 14).
> - The third commit applies `CFLAGS_XCODE14_DEPR_NON_PROTOTYPE` to those parts of AWT lib that generate a compilation error (i.e., avoiding the `passing arguments to a function without prototype`).
> 
> Since the new flag `--enable-xcode14` is not set **the build should run exactly the same on the current XCode versions** and, consequently, the GitHub checks should pass on all platforms, including the current `macos-12` & `XCode 13.4.1`.

Antonio Vieiro has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:

  xcode14:  Use -Wno-deprecated-non-prototype to bypass passing arguments to a function without a prototype

-------------

Changes:
  - all: https://git.openjdk.org/jdk11u-dev/pull/2966/files
  - new: https://git.openjdk.org/jdk11u-dev/pull/2966/files/17ab59d4..fec6eed5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2966&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2966&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk11u-dev/pull/2966.diff
  Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2966/head:pull/2966

PR: https://git.openjdk.org/jdk11u-dev/pull/2966


More information about the jdk-updates-dev mailing list