[jdk11u-dev] RFR: 8344458: [11u] Add initial support for building with XCode 14 [v2]

[Severin Gehwolf]

On Tue, 19 Nov 2024 06:53:34 GMT, Antonio Vieiro <duke at openjdk.org> wrote:

>> An implementation of [JDK-8344458](https://bugs.openjdk.org/browse/JDK-8344458) that adds conditional support for building on `macos` with `XCode 14` while keeping compatibility with previous `XCode` versions.
>> 
>> The PR is separated in three commits for easier review:
>> 
>> - First commit adds a new `--enable-xcode14` configuration flag (which is currently disabled in GHA) and two additional variables:
>>     - `CFLAGS_XCODE14_DEPR_DECLARATIONS` (empty on current XCode versions, set to and `-Wno-deprecated-declarations` when `--enable-xcode14`is used)
>>     - And `CFLAGS_XCODE14_DEPR_NON_PROTOTYPE` (empty on current XCode versions, set to `-Wno-deprecated-non-prototype` when `--enable-xcode14` is used).
>> - The second commit applies `CFLAGS_XCODE14_DEPR_DECLARATIONS` to those parts of the codebase that use the deprecated `sprintf` function (i.e., avoiding `sprintf` usage errors in XCode 14).
>> - The third commit applies `CFLAGS_XCODE14_DEPR_NON_PROTOTYPE` to those parts of AWT lib that generate a compilation error (i.e., avoiding the `passing arguments to a function without prototype`).
>> 
>> Since the new flag `--enable-xcode14` is not set **the build should run exactly the same on the current XCode versions** and, consequently, the GitHub checks should pass on all platforms, including the current `macos-12` & `XCode 13.4.1`.
>
> Antonio Vieiro has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   xcode14:  Use -Wno-deprecated-non-prototype to bypass passing arguments to a function without a prototype

Seems OK to me. I'm not sure we need the doc fixes.

doc/building.html line 317:

> 315: </ul>
> 316: <p>If you have recently (inadvertently) updated your OS and/or Xcode version, and the JDK can no longer be built, please see the section on <a href="#problems-with-the-build-environment">Problems with the Build Environment</a>, and <a href="#getting-help">Getting Help</a> to find out if there are any recent, non-merged patches available for this update.</p>
> 317: <p>Experimental support for XCode 14 can be enabled using the <code>--enable-xcode14</code> configuration flag.</p>

Please remove this. We don't usually update `doc/building.html` for every build change.

doc/building.md line 359:

> 357: 
> 358: Experimental support for XCode 14 can be enabled using the `--enable-xcode14` configuration flag.
> 359: 

Same here.

-------------

PR Review: https://git.openjdk.org/jdk11u-dev/pull/2966#pullrequestreview-2445175160
PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2966#discussion_r1848178932
PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2966#discussion_r1848179371