[jdk21u-dev] RFR: 8342765: [21u] RTM tests assume UnlockExperimentalVMOptions is disabled by default

Paul Hohensee phh at openjdk.org
Wed Oct 23 16:06:08 UTC 2024


On Mon, 21 Oct 2024 22:30:27 GMT, Todd V. Jonker <duke at openjdk.org> wrote:

> Distros with Graal integration will have `UnlockExperimentalVMOptions` enabled, causing several tests in this directory to fail:
> 
> * compiler/rtm/cli/TestRTMAbortThresholdOption.java
> * compiler/rtm/cli/TestRTMLockingCalculationDelayOption.java
> * compiler/rtm/cli/TestRTMLockingThresholdOption.java
> * compiler/rtm/cli/TestRTMSpinLoopCountOption.java
> * compiler/rtm/cli/TestUseRTMForStackLocksOptionOnUnsupportedConfig.java
> * compiler/rtm/cli/TestUseRTMXendForLockBusyOption.java
> 
> This modified the tests to explicitly use `-XX:-UnlockExperimentalVMOptions` when they expecting that context.
> 
> Note that this directory of tests was removed by https://bugs.openjdk.org/browse/JDK-8329141 as part of JDK24.
> 
> Tested using a locally-built JDK+Graal distro, where these tests fails before the change and passes when its applied.

Doesn't affect 23, so lgtm.

-------------

Marked as reviewed by phh (Reviewer).

PR Review: https://git.openjdk.org/jdk21u-dev/pull/1073#pullrequestreview-2389315833


More information about the jdk-updates-dev mailing list