[jdk21u-dev] RFR: 8341779: [REDO BACKPORT] type annotations are not visible to javac plugins across compilation boundaries (JDK-8225377) [v9]

Vicente Romero vromero at openjdk.org
Mon Apr 14 20:53:51 UTC 2025


On Mon, 14 Apr 2025 16:43:33 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote:

>> [JDK-8341779](https://bugs.openjdk.org/browse/JDK-8341779) is a redo of the backport of [JDK-8323093](https://bugs.openjdk.org/browse/JDK-8323093), see also discussion in CSR [JDK-8346471](https://bugs.openjdk.org/browse/JDK-8346471).
>
> Liam Miller-Cushon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'origin/master' into redo-JDK-8341779
>  - Merge remote-tracking branch 'origin/master' into redo-JDK-8341779
>  - Merge remote-tracking branch 'origin/master' into redo-JDK-8341779
>  - Merge remote-tracking branch 'origin/master' into redo-JDK-8341779
>  - Merge remote-tracking branch 'origin/master' into redo-JDK-8341779
>  - Merge remote-tracking branch 'origin/master' into redo-JDK-8341779
>  - Merge branch 'master' into redo-JDK-8341779
>  - 8341779: [REDO BACKPORT] type annotations are not visible to javac plugins across compilation boundaries
>  - Merge remote-tracking branch 'origin/master' into backport-JDK-8336942
>  - Merge remote-tracking branch 'origin/master' into backport-JDK-8336942
>  - ... and 1 more: https://git.openjdk.org/jdk21u-dev/compare/ccce56d6...92dcccb9

Marked as reviewed by vromero (Reviewer).

src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassReader.java line 2298:

> 2296:             }
> 2297:             t.interfaces_field = interfaces.toList();
> 2298:             t.supertype_field = addTypeAnnotations(t.supertype_field, classExtends(65535));

can we use a named constant here instead of a literal?

-------------

PR Review: https://git.openjdk.org/jdk21u-dev/pull/1251#pullrequestreview-2765606722
PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/1251#discussion_r2042898729


More information about the jdk-updates-dev mailing list