[jdk21u-dev] RFR: 8341779: [REDO BACKPORT] type annotations are not visible to javac plugins across compilation boundaries (JDK-8225377) [v9]

[Liam Miller-Cushon]

On Mon, 14 Apr 2025 20:42:37 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Liam Miller-Cushon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
>> 
>>  - Merge remote-tracking branch 'origin/master' into redo-JDK-8341779
>>  - Merge remote-tracking branch 'origin/master' into redo-JDK-8341779
>>  - Merge remote-tracking branch 'origin/master' into redo-JDK-8341779
>>  - Merge remote-tracking branch 'origin/master' into redo-JDK-8341779
>>  - Merge remote-tracking branch 'origin/master' into redo-JDK-8341779
>>  - Merge remote-tracking branch 'origin/master' into redo-JDK-8341779
>>  - Merge branch 'master' into redo-JDK-8341779
>>  - 8341779: [REDO BACKPORT] type annotations are not visible to javac plugins across compilation boundaries
>>  - Merge remote-tracking branch 'origin/master' into backport-JDK-8336942
>>  - Merge remote-tracking branch 'origin/master' into backport-JDK-8336942
>>  - ... and 1 more: https://git.openjdk.org/jdk21u-dev/compare/fc7d4ed9...92dcccb9
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassReader.java line 2298:
> 
>> 2296:             }
>> 2297:             t.interfaces_field = interfaces.toList();
>> 2298:             t.supertype_field = addTypeAnnotations(t.supertype_field, classExtends(65535));
> 
> can we use a named constant here instead of a literal?

That happened as a different change: https://bugs.openjdk.org/browse/JDK-8340024

My understanding was that the best practice for backports was to minimize the number of changes from the original patch, and if a chain of related changes needed to be backported to do them all as separate changes, is that accurate? Would you like me to backport that one as well?

-------------

PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/1251#discussion_r2042965795