[jdk17u-dev] RFR: 8350830: Values converted incorrectly when reading TLS session tickets

[Matthias Baesken]

On Mon, 11 Aug 2025 13:21:16 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

> I backport this for parity with 17.0.17-oracle based on 21.
> 
> Needed more resolves. Several changes are not in 17.
> The resolves are mostly caused by "8291509: Minor cleanup could be done in sun.security"

Please check the  // Get identity len  coding ; otherwise looks okay.

src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java line 474:

> 472:                 this.preSharedKey = new SecretKeySpec(b, alg);
> 473:                 // Get identity len
> 474:                 this.pskIdentity = Record.getBytes8(buf);

Wondering, should we use the coding from jdk here ?

                i = Record.getInt8(buf);
                if (i > 0) {
                    this.pskIdentity = Record.getBytes8(buf);

                } else {
                    this.pskIdentity = null;
                }

-------------

PR Review: https://git.openjdk.org/jdk17u-dev/pull/3833#pullrequestreview-3110178316
PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/3833#discussion_r2269617819