[jdk17u-dev] RFR: 8350830: Values converted incorrectly when reading TLS session tickets

[Goetz Lindenmaier]

On Tue, 12 Aug 2025 12:00:49 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> I backport this for parity with 17.0.17-oracle based on 21.
>> 
>> Needed more resolves. Several changes are not in 17.
>> The resolves are mostly caused by "8291509: Minor cleanup could be done in sun.security"
>
> src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java line 474:
> 
>> 472:                 this.preSharedKey = new SecretKeySpec(b, alg);
>> 473:                 // Get identity len
>> 474:                 this.pskIdentity = Record.getBytes8(buf);
> 
> Wondering, should we use the coding from jdk here ?
> 
>                 i = Record.getInt8(buf);
>                 if (i > 0) {
>                     this.pskIdentity = Record.getBytes8(buf);
> 
>                 } else {
>                     this.pskIdentity = null;
>                 }

The if was added by https://bugs.openjdk.org/browse/JDK-8328608 Multiple NewSessionTicket support for TLS, a larger change with CSR.  I would not pick out a single if and put it here.

-------------

PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/3833#discussion_r2269730939